Lead Actor Swapper script error

[kyonides]

0. In  Ruby indexes start at 0, not 1.

1. Yes, that internal value will get replaced automatically.

2. It looks for anybody in that specific position. The script doesn't know or care about previous swaps.

3. So everybody hates Basil now!?

Here's the updated script!
Please read the embedded comments.  They're worth it!

Code:

# * Kuick Leader Swap XP * #
#   Scripter : Kyonides
#   v1.0.0 - 2025-09-06

# * Script Calls * #

# - Set a Temporary Leader!
#  RememberLeaderIndex? stands for a boolean value: true or false.
#  This new leader becomes permanent if RememberLeaderIndex? is false.
# $game_party.temp_leader(PartyIndex, RememberLeaderIndex?)

# - Restore the Previous Leader! (If Any!)
# $game_party.restore_leader

# - Set a Leader by Actor's ID!
# $game_party.set_leader_by_id(ActorID)

class Game_Party
  def change_leader(n)
    if n < 0
      @actors.unshift @actors.pop
    else
      @actors << @actors.shift
    end
  end

  def set_leader_by_id(actor_id)
    n = @actors.index(actor_id)
    swap_leader(n) if n
  end

  def temp_leader(n, remember)
    @temp_leader_index = n if remember
    swap_leader(n)
  end

  def restore_leader
    return unless @temp_leader_index
    n = @temp_leader_index
    swap_leader(@temp_leader_index)
    @temp_leader_index = nil
  end

  def leader
    @actors[0]
  end
  private
  def swap_leader(n)
    @actors[0], @actors[n] = @actors[n], @actors[0]
    $game_player.refresh
  end
end

class Game_Player
  alias :kyon_kuick_leader_swap_gm_plyr_up :update
  def update
    kyon_kuick_leader_swap_gm_plyr_up
    if Input.trigger?(Input::L)
      $game_party.change_leader(-1)
      refresh
      return
    elsif Input.trigger?(Input::R)
      $game_party.change_leader(1)
      refresh
    end
  end
end

[Ace_V]

0. Got it! I figured as much from previous custom scripts (and the behavior when I selected a value of 1)

1. OK!

2. This is perfect.  

3. I know, right? What did he ever do (I remember him as a peacemaker)  

4. I tested out the updated script, and tried this set-up for a test event: 

Code:

@> Conditional Branch: [Aluxes] is in the party
  @> Script: $game_party.set_leader_by_id(1)
  @>
 : Else
  @>
 : Branch End

But nothing seems to happen.   I made sure Aluxes was in the party and that he wasn't the leader when I interacted with the test event.

[kyonides]

I forgot to include an important step, to pass the actor's ID to the $game_actors array before looking for his current position.
 Stuff happens, you know.

Here's the fixed code!

Code:

# * Kuick Leader Swap XP * #
#  Scripter : Kyonides
#  v1.0.2 - 2025-09-06

# * Script Calls * #

# - Set a Temporary Leader!
#  RememberLeaderIndex? stands for a boolean value: true or false.
#  This new leader becomes permanent if RememberLeaderIndex? is false.
# $game_party.temp_leader(PartyIndex, RememberLeaderIndex?)

# - Restore the Previous Leader! (If Any!)
# $game_party.restore_leader

# - Set a Leader by Actor's ID!
# $game_party.set_leader_by_id(ActorID)

class Game_Party
  def change_leader(n)
    if n < 0
      @actors.unshift @actors.pop
    else
      @actors << @actors.shift
    end
  end

  def set_leader_by_id(actor_id)
    actor = $game_actors[actor_id]
    n = @actors.index(actor)
    swap_leader(n) if n and n != 0
  end

  def temp_leader(n, remember)
    @temp_leader_index = n if remember
    swap_leader(n)
  end

  def restore_leader
    return unless @temp_leader_index
    n = @temp_leader_index
    swap_leader(@temp_leader_index)
    @temp_leader_index = nil
  end

  def leader
    @actors[0]
  end
  private
  def swap_leader(n)
    @actors[0], @actors[n] = @actors[n], @actors[0]
    $game_player.refresh
  end
end

class Game_Player
  alias :kyon_kuick_leader_swap_gm_plyr_up :update
  def update
    kyon_kuick_leader_swap_gm_plyr_up
    if Input.trigger?(Input::L)
      $game_party.change_leader(-1)
      refresh
      return
    elsif Input.trigger?(Input::R)
      $game_party.change_leader(1)
      refresh
    end
  end
end

[DerVVulfman]

Thank you so much for these two scripts!! I tried them both but Dervv's script seems to only move around the caterpillar and not the main character? (the three characters behind do swap around, but it duplicates the lead into the second, then into the third, and fourth, but the lead doesn't swap out for some reason.)

I'm puzzled.   It works just as its meant with no duplication of the lead actor.  Video attached. 

Couple that, it affects the entire party, and not just the caterpillar system.  For any caterpillar script, the party leading the caterpillar script must be the actual party leader, not some designated temp leader. So the party itself must reflect who is in the lead. The caterpillar system is completely dependent upon the party and its order.

You and kyonides seem to be in a more compatible set of time-zones, so I'll back away from the repair. However, if you have an issue with my script not functioning as above that there may also be something else in play.

[Ace_V]

I forgot to include an important step, to pass the actor's ID to the $game_actors array before looking for his current position.
 Stuff happens, you know.

Here's the fixed code!

Code:

--------------------------

This works perfectly now!! Also reorders the party in the menu and is really easy to implement the script call. I'm going to go through my older quests to swap characters around. Thank you so much, kyonides!

Thank you so much for these two scripts!! I tried them both but Dervv's script seems to only move around the caterpillar and not the main character? (the three characters behind do swap around, but it duplicates the lead into the second, then into the third, and fourth, but the lead doesn't swap out for some reason.)

I'm puzzled.   It works just as its meant with no duplication of the lead actor.  Video attached. 

Couple that, it affects the entire party, and not just the caterpillar system.  For any caterpillar script, the party leading the caterpillar script must be the actual party leader, not some designated temp leader.  So the party itself must reflect who is in the lead.  The caterpillar system is completely dependent upon the party and its order.

You and kyonides seem to be in a more compatible set of time-zones, so I'll back away from the repair.  However,  if you have an issue with my script not functioning as above that there may also be something else in play.

It really is odd! I tested your script on a blank project that also contained my game's scripts.rxdata just now and it still duplicates the lead for some reason.   (Though I was able to get Basil back by cycling a few more times until there was no more duplicate of Aluxes, haha)
I appreciate all the help with this request despite the time zone difference! It also gave me a reason to look over my game's various scripts and I began rediscovering what my 2005 self was tinkering with back then. (among other things, I had forgotten I implemented a janky regen script that involved changing some of the standard scripts instead of being a new entry in itself, and it changed the regen text color as well) The little break from graphics and event-work was also refreshing.

[DerVVulfman]

It really is odd! I tested your script on a blank project that also contained my game's scripts.rxdata just now and it still duplicates the lead for some reason.   (Though I was able to get Basil back by cycling a few more times until there was no more duplicate of Aluxes, haha)

Its not a blank script if it contains your game's current scripts.rxdata.  A blank project with only those scripts that come default are the test, such as this:  
  Project1ddd.zip (Size: 923.2 KB / Downloads: 6)

Otherwise, you may have other code that is itself interfering... rewrites or direct edits otherwise.  Content you may have forgotten.